Skip to content

Fix various typos #13785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix various typos #13785

merged 1 commit into from
Dec 5, 2024

Conversation

BD103
Copy link
Contributor

@BD103 BD103 commented Dec 5, 2024 •
edited by blyxyas
Loading

I ran Typos on the project and fixed all of the easy spelling mistakes! I made sure to avoid UI tests, since those changes are more challenging to review due to the changes in .stderr files.

changelog: Fixed several typos.
  • cargo test passes locally
  • Run cargo dev fmt

@rustbot
Copy link
Collaborator

rustbot commented Dec 5, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @blyxyas (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 5, 2024
@BD103 BD103 changed the title fix: various typos Fix various typos Dec 5, 2024
blyxyas
blyxyas approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

We can remove the changelog, as to not put more strain on the people that make the changelog PRs. (A.K.A Fred) The changelog is only included for user-facing PRs (like fixing bugs or adding lints).

For internal PRs, use changelog: none

@BD103
Copy link
Contributor Author

BD103 commented Dec 5, 2024

We can remove the changelog, as to not put more strain on the people that make the changelog PRs. (A.K.A Fred) The changelog is only included for user-facing PRs (like fixing bugs or adding lints).

Sounds good! I wasn't sure if I should add it to the changelog, since it does change public documentation. Fixed :)

@blyxyas
Copy link
Member

blyxyas commented Dec 5, 2024

Oh, I didn't notice the triple slash. I'm what some might call quite a silly person.
I'll merge, thanks for the contribution! ❤️

@blyxyas blyxyas added this pull request to the merge queue Dec 5, 2024
Merged via the queue into rust-lang:master with commit f83a227 Dec 5, 2024
9 checks passed
@BD103 BD103 deleted the receiver-typo branch December 5, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BD103 @rustbot @blyxyas